Adding cacheable variable to parse_leapp_report #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapdisk
requested changes
Sep 30, 2024
|
The newly introduced var also should be added to the role README.md. |
|
it looks like your rebase went bad and you pulled in a lot of the other recent PRs changes as well. at this point I am not sure if it would be easier to start fresh and then add your changes back in from there. |
|
Fixed the lint issue, updated the readme, and thank you @swapdisk for helping me fix my rebase issue! |
djdanielsson
requested changes
Oct 23, 2024
| @@ -8,7 +8,7 @@ The `parse_leapp_report` role is used by the `analysis` or `upgrade` roles to ch | |||
| |-------------------------|-----------------------|-----------------------------------------------------| | |||
| | result_filename | "/var/log/leapp/leapp-report.txt" | Path of the Leapp pre-upgrade report file. | | |||
| | result_filename_prefix | "/var/log/leapp/leapp-report | The path used and the prefix name setting for the Leapp report | | |||
| | result_filename_json | "{{ result_filename_prefix }}.json | JSON filename using the selected "result_filename_prefix" | | |||
There was a problem hiding this comment.
Looks like you deleted this line, can you put it back because it doesn't look like it should be deleted then it looks good
| leapp_report_txt: "{{ results_txt.content | b64decode | split('\n') }}" | ||
| leapp_report_json: "{{ results_json.content | b64decode | from_json }}" | ||
|
|
||
| - name: Check for inhibitors | ||
| ansible.builtin.set_fact: | ||
| cacheable: "{{ result_fact_cacheable }}" |
There was a problem hiding this comment.
you need to fix the spacing here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a variablized argument to allow this to be run from AAP and capture the reporting when an aggregator isn't available.